Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AppNexus debug auction via cookie #3314

Merged
merged 4 commits into from
Dec 10, 2018
Merged

AppNexus debug auction via cookie #3314

merged 4 commits into from
Dec 10, 2018

Conversation

aneuway2
Copy link
Contributor

Type of change

  • Feature

Description of change

The following feature enhancement adds in the ability for a publisher or developer to request an AppNexus debug auction in the response back from AppNexus alongside any bids.

This feature can be enabled by doing the following:

  1. Adding the pbjs_debug=true query string parameter.
  2. By setting an apn_prebid_debug cookie with a JSON string. For example:
{ "enabled": true, "dongle": "QWERTY", "debug_timeout": 1000, "member_id": 958 }

Sample Console Log:

Running member 958 debug using no permissions
Impbus 4280.bm-impbus.prod.nym2:8001
	Header Referer: http://example.com?pbjs_debug=true&ast_debug=true&ast_dongle=sss
	Site Domain: example.com
1772142023491463321 - Predicted engagement_rate_id: 2 (view) imps 54.87%
1772142023491463321 - Predicted engagement_rate_id: 3 (view_over_total) imps 51.57%
1772142023491463321 - Predicted engagement_rate_id: 8 (predicted_100pv1s_display_view_rate) imps 47.06%

@aneuway2 aneuway2 mentioned this pull request Nov 20, 2018
Merged
mkendall07
mkendall07 reviewed Nov 21, 2018
View reviewed changes
modules/appnexusBidAdapter.js Outdated
@@ -450,6 +491,11 @@ function hasAppId(bid) {
return !!bid.params.app
}

function getCookie(name) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you move this into utils ?

@aneuway2
Copy link
Contributor Author

aneuway2 commented Dec 3, 2018

@jsnellbaker @mkendall07 added getCookie to utils

@mkendall07
Copy link
Member

This pull request introduces 1 alert when merging 9615c67 into 7aef26e - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

Comment posted by LGTM.com

@jsnellbaker jsnellbaker added the needs 2nd review Core module updates require two approvals from the core team label Dec 4, 2018
mkendall07
mkendall07 approved these changes Dec 10, 2018
View reviewed changes
Copy link
Member

@mkendall07 mkendall07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkendall07 mkendall07 merged commit 88156e7 into prebid:master Dec 10, 2018
pedrolopezmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Mar 18, 2019
@aneuway2
AppNexus debug auction via cookie (prebid#3314)
f2a7761 
* updating appnexus debug auction to be cookie-only

* adding getCookie to utils

* remove LGTM alert on getCookie

* fix failed tests
@jsnellbaker jsnellbaker mentioned this pull request Oct 7, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsnellbaker jsnellbaker jsnellbaker approved these changes

@mkendall07 mkendall07 mkendall07 approved these changes

Assignees

@mkendall07 mkendall07

@jsnellbaker jsnellbaker

Labels
needs 2nd review Core module updates require two approvals from the core team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aneuway2 @mkendall07 @jsnellbaker